Re: [RFC PATCH 0/5] Localise error headers

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 3, 2017, 12:26 UTC
Message-ID: <CACsJy8A123cdEn03p590Hxdg5fujdDAH3BU8s9hZmuOY6ok3sg@mail.gmail.com>
In-Reply-To: <cover.1483354746.git.git@drmicha.warpmail.net>

On Mon, Jan 2, 2017 at 6:14 PM, Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 9 quoted lines

> Currently, the headers "error: ", "warning: " etc. - generated by die(),
> warning() etc. - are not localized, but we feed many localized error messages
> into these functions so that we produce error messages with mixed localisation.
>
> This series introduces variants of die() etc. that use localised variants of
> the headers, i.e. _("error: ") etc., and are to be fed localized messages. So,
> instead of die(_("not workee")), which would produce a mixed localisation (such
> as "error: geht ned"), one should use die_(_("not workee")) (resulting in
> "Fehler: geht ned").

Another option, not as thorough, but less effort, is changing die/err/warn default routines to the "porcelain" versions where we do _("fatal:") internally _with_ die(), not die_(). We can set this for porcelain commands that we know can be fully i18n-ized. Then maybe die_() will fill in the gap if there's still need for it.

-- 
Duy