Re: [PATCH v8 0/2] builtin/config.c: support `--type=<type>` as preferred alias for `--type`

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2018, 03:11 UTC
Message-ID: <xmqq1sfmzbbg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180411013309.GA36066@syl.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 13 quoted lines

>> > +#define OPT_CALLBACK_VALUE(s, l, h, f, i) \
>> > +	{ OPTION_CALLBACK, (s), (l), NULL, NULL, (h), PARSE_OPT_NOARG | \
>> > +	PARSE_OPT_NONEG, (f), (i) }
>> > +
>> > +static struct option builtin_config_options[];
>>
>> OK.  I am not sure if OPT_CALLBACK_VALUE() needs to take 'f', as you
>> always pass the option_parse_type function to it.
>
> That's fair. I left this in as an indication that something like this
> _might_ want to make its way into parse-options.h as a general-purpose
> utility, but was not yet ready to do so. Thus, I defined it inside
> builtin/config.c.

I understood the reasoning, but as your current verdict is that this is not yet ready for parse-options.[ch], I think it is probably preferrable to reduce repeated passing of the same function to the macro, at least while it is in this builgin/config.c file.

Show 8 quoted lines

> @@ -71,7 +71,7 @@ static int option_parse_type(const struct option *opt, const char *arg,
>  			     int unset)
>  {
>  	if (unset) {
> -		type = 0;
> +		*((int *) opt->value) = 0;
>  		return 0;
>  	}

Yup. This (if it works) is exactly what I imagined the function should look like.