Re: [PATCH v4 0/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

From: Jeff King <peff@peff.net>
Date: Apr 5, 2018, 21:58 UTC
Message-ID: <20180405215759.GB29117@sigill.intra.peff.net>
In-Reply-To: <20180405020034.GA8879@syl.local>

On Wed, Apr 04, 2018 at 07:00:34PM -0700, Taylor Blau wrote:

Show 12 quoted lines

> I have attached a fourth re-roll of my series to introduce
> "--type=<type>" in "git config", and prefer it to "--<type>".
> 
> In particular, since the last update, I have changed the following:
> 
>   - Clearer wording in the second patch per Eric's suggestion.
> 
>   - Stopped spelling the required argument to "--type=" as "[type]", and
>     instead as "<type>" (cc: Eric).
> 
>   - Changed "unexpected" to "unrecognized" in the fatal message when we
>     don't know how to interpret the argument to "--type".

This iteration looks good to me, assuming that last-one-wins is still the direction we want to go. I'm open to the notion that the cleanup is not worth the change in behavior. It is IMHO, but obviously it's somewhat subjective.

-Peff