Re: [PATCH v4 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Apr 5, 2018, 22:15 UTC
- Message-ID
- <20180405221500.GA87758@syl.local>
- In-Reply-To
- <20180405221201.GA29929@sigill.intra.peff.net>
On Thu, Apr 05, 2018 at 06:12:02PM -0400, Jeff King wrote:
Show 10 quoted lines
> On Wed, Apr 04, 2018 at 07:02:38PM -0700, Taylor Blau wrote: > > > +test_expect_success '--no-type unsets type specifiers' ' > > + echo "10" > expect && > > + git config --type=bool --no-type core.number >actual && > > + test_cmp expect actual > > +' > > Actually, one minor nit (not worth a re-roll, but Junio may want to mark > it up): drop the space in "> expect".
Ack; I thought I picked this one up. I am happy to re-roll it, but maybe it makes to amend while queueing.
Thanks, Taylor