Re: [PATCH] submodule: add config for where gitdirs are located

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2018, 22:03 UTC
Message-ID: <xmqq1sasbsra.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180816181940.46114-1-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

Show 10 quoted lines

> Introduce the config "submodule.<name>.gitdirpath" which is used to
> indicate where a submodule's gitdir is located inside of a repository's
> "modules" directory.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>
> Maybe something like this on top?  Do you think we should disallow
> "../" in this config, even though it is a repository local
> configuration and not shipped in .gitmodules?

Sounds sensible to start strict and loosen later if/when necessary.

If we disallow "../", shouldn't we also reject an absolute path (meaning, you can only specify a subdirectory of $GIT_DIR/modules/ in the super-project)?