Re: [PATCH 2/2] submodule: munge paths to submodule git directories

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 29, 2018, 21:09 UTC
Message-ID: <20180829210913.GF7547@aiede.svl.corp.google.com>
In-Reply-To: <20180829052519.GA17253@sigill.intra.peff.net>

Jeff King wrote:

> On Tue, Aug 28, 2018 at 02:35:25PM -0700, Stefan Beller wrote:

Show 7 quoted lines

>> Yeah, then let's just convert '/' with as little overhead as possible.
>
> Do you care about case-folding issues (e.g., submodules "FOO" and "foo"
> colliding)?
>
> I'm OK if the answer is "no", but if you do want to deal with it, the
> time is probably now.

Have we rejected the config approach? I really liked the attribute of not having to solve everything right away. I'm getting scared that we've forgotten that goal.

It mixes well with Stefan's idea of setting up a new .git/submodules/ directory. We could require that everything in .git/submodules/ have configuration (or that everything in that directory either have configuration or be the result of a "very simple" transformation) and that way, all ambiguity goes away.

Part of the definition of "very simple" could be that the submodule name must consist of some whitelisted list of characters (including no uppercase), for example.

Thanks, Jonathan