Re: [PATCH 2/2] submodule: munge paths to submodule git directories

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 29, 2018, 21:18 UTC
Message-ID: <20180829211802.GG7547@aiede.svl.corp.google.com>
In-Reply-To: <CAGZ79kYJTWROYSGjEbdVBsEAkWkNE4QVCiPVfuMf75d13fXN6A@mail.gmail.com>

Hi,

Stefan Beller wrote:

Show 11 quoted lines

>> Yes, that makes even the capitalized "CON" issues go away. It's not a
>> one-to-one mapping, though ("foo-" and "foo_" map to the same entity).
>
> foo_ would map to foo__, and foo- would map to something else.
> (foo- as we do not rewrite dashes, yet?)
>
>> If we want that, too, I think something like url-encoding is fine, with
>> the caveat that we simply urlencode _more_ things (i.e., anything not in
>> [a-z_]).
>
> Yeah I think we need more than url encoding now.

Can you say more? Perhaps my expectations have been poisoned by tools like dpkg-buildpackage that use urlencode. As far as I can tell, it works fine.

Moreover, urlencode has some attributes that make it a good potential fit: it's intuitive, it's unambiguous (yes, it's one-to-many, but at least it's not many-to-many), and people know how to deal with it from their lives using browsers. Can you spell out for me what problem we're solving with something more custom?

Stepping back, I am very worried about any design that doesn't give us the ability to tweak things later. See [1] and [2] for more on that subject.

Thanks, Jonathan

[1] https://public-inbox.org/git/20180816023446.GA127655@aiede.svl.corp.google.com/ [2] https://public-inbox.org/git/20180829210913.GF7547@aiede.svl.corp.google.com/