Re: [PATCH 2/2] submodule: munge paths to submodule git directories

From: Jeff King <peff@peff.net>
Date: Aug 29, 2018, 21:32 UTC
Message-ID: <20180829213217.GB32400@sigill.intra.peff.net>
In-Reply-To: <20180829210913.GF7547@aiede.svl.corp.google.com>

On Wed, Aug 29, 2018 at 02:09:13PM -0700, Jonathan Nieder wrote:

Show 14 quoted lines

> Jeff King wrote:
> > On Tue, Aug 28, 2018 at 02:35:25PM -0700, Stefan Beller wrote:
> 
> >> Yeah, then let's just convert '/' with as little overhead as possible.
> >
> > Do you care about case-folding issues (e.g., submodules "FOO" and "foo"
> > colliding)?
> >
> > I'm OK if the answer is "no", but if you do want to deal with it, the
> > time is probably now.
> 
> Have we rejected the config approach?  I really liked the attribute of
> not having to solve everything right away.  I'm getting scared that
> we've forgotten that goal.

I personally have no problem with that approach, but I also haven't thought that hard about it (I was mostly ignoring the discussion since it seemed like submodule-interested folks, but I happened to see what looked like a potentially bad idea cc'd to me ;) ).

-Peff