git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] fetch: support hideRefs to speed up connectivity checks

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 10, 2023, 22:56 UTC
Message-ID
<xmqq1qmxgmed.fsf@gitster.g>
In-Reply-To
<20230209122857.M669733@dcvr>
Eric Wong <e@80x24.org> writes:
> Not sure if this is the right way to go about this...
> If it's close, maybe --exclude-hidden=fetch can be supported.
Yeah, why not.

I however notice error handling in the codepath that deals with "--exclude-hidden" is a bit sloppy.

refs.c::parse_hide_refs_config() is nice enough to diagnose a malformed transfer.hiderefs configuration as an error by returning -1, and revision.c::hide_refs_config() propagates such an error up, but revision.c::exclude_hidden_refs() ignores the error from git_config(), and revision.c::handle_revision_pseudo_opt() ignores any error from exclude_hidden_refs() anyway.

We may want to tighten it a bit before (ab)using the option in more contexts.

Thanks.
Previous: Eric WongNext: Eric Wong
Message 4 of 11 in “[RFC] fetch: support hideRefs to speed up connectivity checks”
  1. Eric WongFeb 9, 2023
  2. Jonathan TanFeb 10, 2023
  3. Eric WongFeb 10, 2023
  4. Junio C HamanoFeb 10, 2023
  5. Eric WongFeb 11, 2023
  6. Junio C HamanoFeb 11, 2023
  7. fetch: support hideRefs to speed up connectivity checksEric Wong, Feb 12, 2023
  8. Jeff KingFeb 13, 2023
  9. Philip OakleyFeb 13, 2023
  10. Jeff KingFeb 14, 2023
  11. Eric WongFeb 16, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.