Re: [PATCH v2] fetch: support hideRefs to speed up connectivity checks
- From
Jeff King <peff@peff.net>
- Date
- Feb 13, 2023, 20:53 UTC
- Message-ID
- <Y+qjRZTn7DNib1uB@coredump.intra.peff.net>
- In-Reply-To
- <20230212090426.M558990@dcvr>
On Sun, Feb 12, 2023 at 09:04:26AM +0000, Eric Wong wrote:
> Sidenote: I'm curious about the reason $(pwd) is used in some > places while $PWD seems fine in others, so it doesn't seem to be > a portability problem. I chose $PWD since it's faster.
It sometimes matters; one is a Windows path (with "C:\", etc) and one is a Unix-style path. Many spots are happy with either type, but it sometimes bites us when doing string comparisons, or in a few specific cases. See
https://lore.kernel.org/git/d36d8b51-f2d7-a2f5-89ea-369f49556e10@kdbg.org/
for an example.
-Peff