Re: [PATCH v2] fetch: support hideRefs to speed up connectivity checks

From: Philip Oakley <philipoakley@iee.email>
Date: Feb 13, 2023, 23:30 UTC
Message-ID: <13cef8e7-71af-27a5-77a3-a08f75720d1a@iee.email>
In-Reply-To: <Y+qjRZTn7DNib1uB@coredump.intra.peff.net>

On 13/02/2023 20:53, Jeff King wrote:

Show 14 quoted lines

> On Sun, Feb 12, 2023 at 09:04:26AM +0000, Eric Wong wrote:
>
>>  Sidenote: I'm curious about the reason $(pwd) is used in some
>>  places while $PWD seems fine in others, so it doesn't seem to be
>>  a portability problem.  I chose $PWD since it's faster.
> It sometimes matters; one is a Windows path (with "C:\", etc) and one is
> a Unix-style path. Many spots are happy with either type, but it
> sometimes bites us when doing string comparisons, or in a few specific
> cases. See
>
>   https://lore.kernel.org/git/d36d8b51-f2d7-a2f5-89ea-369f49556e10@kdbg.org/
>
> for an example.
>

There is guidance in t/README L680-684 though it maybe not that easy to spot.

A more recent patch was https://lore.kernel.org/git/4f5c5633-f5a2-3c99-329e-3057b8d447d2@kdbg.org/ with slightly more details.

Philip