Re: [PATCH v2] fetch: support hideRefs to speed up connectivity checks

From: Eric Wong <e@80x24.org>
Date: Feb 16, 2023, 01:32 UTC
Message-ID: <20230216013237.M252435@dcvr>
In-Reply-To: <Y+rmlcRoP1aMioTC@coredump.intra.peff.net>

Jeff King <peff@peff.net> wrote:

Show 26 quoted lines

> On Mon, Feb 13, 2023 at 11:30:35PM +0000, Philip Oakley wrote:
> > On 13/02/2023 20:53, Jeff King wrote:
> > > On Sun, Feb 12, 2023 at 09:04:26AM +0000, Eric Wong wrote:
> > >
> > >>  Sidenote: I'm curious about the reason $(pwd) is used in some
> > >>  places while $PWD seems fine in others, so it doesn't seem to be
> > >>  a portability problem.  I chose $PWD since it's faster.
> > > It sometimes matters; one is a Windows path (with "C:\", etc) and one is
> > > a Unix-style path. Many spots are happy with either type, but it
> > > sometimes bites us when doing string comparisons, or in a few specific
> > > cases. See
> > >
> > >   https://lore.kernel.org/git/d36d8b51-f2d7-a2f5-89ea-369f49556e10@kdbg.org/
> > >
> > > for an example.
> > >
> > There is guidance in t/README L680-684 though it maybe not that easy to
> > spot.
> > 
> > A more recent patch was
> > https://lore.kernel.org/git/4f5c5633-f5a2-3c99-329e-3057b8d447d2@kdbg.org/
> > with slightly more details.
> 
> Thanks, both explanations are much better than the one I found (my
> digging in the archive consisted of "I know JSixt has corrected me on
> this at least once...").

Thanks both. Looks like my use of GIT_TRACE="$PWD"/trace is fine and there's plenty of examples where $PWD is used for GIT_TRACE* in our test suite (`git grep GIT_TRACE.*PWD')

Any comments on the actual change itself?  Thanks again.