Re: [PATCH] tag: error when git-column fails

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2024, 01:35 UTC
Message-ID: <xmqq1q9f25ga.fsf@gitster.g>
In-Reply-To: <59df085d-0de8-45b1-9b8b-c69e91e56a1f@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 7 quoted lines

> @@ -530,7 +530,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
>  			struct column_options copts;
>  			memset(&copts, 0, sizeof(copts));
>  			copts.padding = 2;
> -			run_column_filter(colopts, &copts);
> +			if (run_column_filter(colopts, &copts))
> +				die(_("could not start 'git column'"));

Nice.  This obvious omission should have been here from the day one.

Will queue.  Thanks.

>  		}
>  		filter.name_patterns = argv;
>  		ret = list_tags(&filter, sorting, &format);

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.