Re: [PATCH] column: disallow negative padding

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Feb 11, 2024, 18:18 UTC
Message-ID: <34c18fd0-1fa3-4226-b5a1-b019fcb05548@app.fastmail.com>
In-Reply-To: <xmqqle7q997e.fsf@gitster.g>

On Sun, Feb 11, 2024, at 18:55, Junio C Hamano wrote:

Show 12 quoted lines

> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
>> Yeah, thanks. You probably saved me a v3. :)
>>
>> Although I failed to notice that the string I stole was just a plain
>> string, not a translation string. And apparently there are no generic
>> “non-negative” translation strings. So I’ll just make a new one.
>
> The last time I took a look, I thought there were more than just the
> single entry point you patched that can feed negative padding into
> the machinery?  Don't you need to cover them as well?
>
> Thanks.

I’ve incorporated the `column.c` patch you posted in my not-yet-published v2. Hopefully that was it.(? :) ) I’ll take another look.

v2 is finished now so maybe I’ll send it out soon.

-- 
Kristoffer Haugsbakk