From: Junio C Hamano Date: Wed, 14 Feb 2024 01:35:33 GMT Subject: Re: [PATCH] tag: error when git-column fails Message-ID: In-Reply-To: <59df085d-0de8-45b1-9b8b-c69e91e56a1f@gmail.com> Rubén Justo writes: > @@ -530,7 +530,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix) > struct column_options copts; > memset(&copts, 0, sizeof(copts)); > copts.padding = 2; > - run_column_filter(colopts, &copts); > + if (run_column_filter(colopts, &copts)) > + die(_("could not start 'git column'")); Nice. This obvious omission should have been here from the day one. Will queue. Thanks. > } > filter.name_patterns = argv; > ret = list_tags(&filter, sorting, &format);