Re: git column fails (or crashes) if padding is negative
- From
Kristoffer Haugsbakk <code@khaugsbakk.name>
- Date
- Feb 9, 2024, 16:27 UTC
- Message-ID
- <571fb353-af1d-4cc9-a2c2-197296685623@app.fastmail.com>
- In-Reply-To
- <AS8P189MB21977ACC4866D9836DA29082BC4B2@AS8P189MB2197.EURP189.PROD.OUTLOOK.COM>
Hi
I wasn’t able to reproduce quite what you got but kind of the same.
``` $ seq 1 24 | git column --mode=column --padding=-1 12345678910<binary?><numbers> $ seq 1 24 | git column --mode=column --padding=-3 fatal: Data too large to fit into virtual memory space. $ seq 1 24 | git column --mode=column --padding=-5 fatal: Out of memory, malloc failed (tried to allocate 18446744073709551614 bytes) ```
This is an “Internal helper command” under the “plumbing” suite. And I get the impression that sometimes these fallthroughs are treated as “don’t do that”. But I don’t know.
On the other hand it failing inside malloc looks weird. Why not catch this before the malloc call is made?
[System Info] git version: git version 2.43.0 cpu: x86_64 no commit associated with this build sizeof-long: 8 sizeof-size_t: 8 shell-path: /bin/sh uname: Linux 6.5.0-17-generic #17~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jan 16 14:32:32 UTC 2 x86_64 compiler info: gnuc: 11.4 libc info: glibc: 2.35 $SHELL (typically, interactive shell): /bin/bash
[Enabled Hooks]
-- Kristoffer Haugsbakk