Re: [PATCH v4 0/3] advice: add "all" option to disable all hints

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2024, 16:47 UTC
Message-ID: <xmqq1q6e3n0i.fsf@gitster.g>
In-Reply-To: <D125SZ21UPI0.166ZOVLTOBCRH@jamesliu.io>

"James Liu" <james@jamesliu.io> writes:

Show 13 quoted lines

> On Mon May 6, 2024 at 9:20 AM AEST, James Liu wrote:
>> On Sat May 4, 2024 at 3:25 AM AEST, Junio C Hamano wrote:
>> > > Subject: Re: [PATCH v4 0/3] advice: add "all" option to disable all hints
>> >
>> > Huh?  Do we have "all" option that disable everything?
>>
>> Oops, I think I mistakenly copied the subject from the original cover
>> letter. I don't suppose this warrants a v5, does it?
>>
>> Cheers,
>> James
>
> Ahh, I didn't see Karthik's feedback. Will prepare a new version.

I count two messages from Karthik for v4, one of them being "this round looks good", to which you said "thanks".

If you mean the other comment about a non-sentence in the proposed log message of [2/3], the copy I have in 'seen' says this:

    doc: add spacing around paginate options

    Make the documentation page consistent with the usage string printed by
    "git help git" and consistent with the description of "[-v | --version]"
    option.

    Signed-off-by: James Liu <james@jamesliu.io>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

If that looks good enough to both of you, then we can probably declare victory and mark the topic for 'next'.

Thanks.