[PATCH v4 0/3] advice: add "all" option to disable all hints

Hi,

Thank you all for the comprehensive feedback. This is v4 of the patch series to introduce a --no-advice option for silencing advice hints.

The main changes are:

- Two preliminary commits to reorder/clean up the options documentation
  and usage string.
- Caching the value of GIT_ADVICE.
- Adding tests which explicitly set GIT_ADVICE to false and true.

Cheers, James

James Liu (3):
  doc: clean up usage documentation for --no-* opts
  doc: add spacing around paginate options
  advice: add --no-advice global option

 Documentation/git.txt | 18 +++++++-----
 advice.c              |  7 +++++
 environment.h         |  7 +++++
 git.c                 | 11 +++++--
 t/t0018-advice.sh     | 68 +++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 101 insertions(+), 10 deletions(-)

Range-diff against v3: 1: 55d5559586 < -: ---------- advice: add --no-advice global option -: ---------- > 1: ae3f45dadc doc: clean up usage documentation for --no-* opts -: ---------- > 2: 1b0019026a doc: add spacing around paginate options -: ---------- > 3: 31e73e6c0e advice: add --no-advice global option