Re: Re* [PATCH v4 0/3] advice: add "all" option to disable all hints
- From
- Dragan Simic <dsimic@manjaro.org>
- Date
- May 7, 2024, 00:01 UTC
- Message-ID
- <8dca4ecbf85f36e4264d7587fde4b0d5@manjaro.org>
- In-Reply-To
- <CAPig+cT-xk13jGEUmpT5QmwVYTxKNUZsu9xJ=Ph3h4AzKHg6pA@mail.gmail.com>
Hello Eric,
On 2024-05-03 23:24, Eric Sunshine wrote:
Show 18 quoted lines
> On Fri, May 3, 2024 at 4:08 PM Junio C Hamano <gitster@pobox.com> > wrote: >> So, yes, --creation-factor=<value> is messy, I think a very high >> value, much higher than the hardcoded default of 60, is more >> appropriate for use in format-patch, but we do not know what bad >> effect it would have if we used much higher default everywhere. > > At this point in time, I'm not particularly against giving `git > format-patch` its own default creation-factor. > > My only worry (and perhaps it's very minor) is that separate default > creation-factors for `git range-diff` and `git format-patch > --range-diff` could catch the unwary off-guard when invoking `git > range-diff` to manually check the difference between an old an new > version of a series before finally invoking `git format-patch > --range-diff` to actually create the patches for sending. (I've done > this myself on a very few occasions, but perhaps not often enough to > warrant the concern(?).)
I agree that having two different default values for the creation factor in "git format-patch" and "git range-diff" is a valid concern, but I think that the resulting benefits, in form of patch submissions that don't lack the range diff contents, outweigh this concern.