Re: [PATCH v4 0/3] advice: add "all" option to disable all hints

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 7, 2024, 06:23 UTC
Message-ID: <CAOLa=ZTwdLPYqeDh=HPf6tQqBfeTjQV6syE_sxtgWE_Cj48tvg@mail.gmail.com>
In-Reply-To: <D12XUEC6DL6O.POVU09JJFHO9@jamesliu.io>

Hello,

"James Liu" <james@jamesliu.io> writes:

Show 25 quoted lines

> On Tue May 7, 2024 at 2:47 AM AEST, Junio C Hamano wrote:
>> I count two messages from Karthik for v4, one of them being "this
>> round looks good", to which you said "thanks".
>>
>> If you mean the other comment about a non-sentence in the proposed
>> log message of [2/3], the copy I have in 'seen' says this:
>>
>>     doc: add spacing around paginate options
>>
>>     Make the documentation page consistent with the usage string printed by
>>     "git help git" and consistent with the description of "[-v | --version]"
>>     option.
>>
>>     Signed-off-by: James Liu <james@jamesliu.io>
>>     Signed-off-by: Junio C Hamano <gitster@pobox.com>
>>
>> If that looks good enough to both of you, then we can probably
>> declare victory and mark the topic for 'next'.
>>
>> Thanks.
>
> Yes I'm happy with that. Thanks Junio!
>
> Cheers,
> James

Looks good to me too :)

Thanks Karthik