Re: [PATCH v6 3/5] builtin/stash: factor out revision parsing into a function

From: Junio C Hamano <gitster@pobox.com>
Date: May 22, 2025, 20:34 UTC
Message-ID: <xmqq1psg5qrb.fsf@gitster.g>
In-Reply-To: <20250522185524.18398-5-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> +	strbuf_init(&info->revision, 0);
> +	if (parse_stash_revision(&info->revision, commit, 0)) {
> +		return -1;
>  	}

It does not look like this series add more code inside this block in a later step, so let's lose the unnecessary {braces} around a single statement "return -1" here.

By the way, what is "pwodd" I saw in the e-mail header?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.