Re: [PATCH v6 3/5] builtin/stash: factor out revision parsing into a function
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- May 23, 2025, 23:25 UTC
- Message-ID
- <aDED4MrweIc0N51h@tapette.crustytoothpaste.net>
- In-Reply-To
- <xmqq1psg5qrb.fsf@gitster.g>
On 2025-05-22 at 20:34:16, Junio C Hamano wrote:
Show 10 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > + strbuf_init(&info->revision, 0);
> > + if (parse_stash_revision(&info->revision, commit, 0)) {
> > + return -1;
> > }
>
> It does not look like this series add more code inside this block in
> a later step, so let's lose the unnecessary {braces} around a single
> statement "return -1" here.Sounds good. I'll fix that in a v7.
> By the way, what is "pwodd" I saw in the e-mail header?
A typo for "pwood", which is my alias for Phillip Wood, who I intended to CC. A typo which I unfortunately didn't catch before sending out patches (mostly because I was sitting in an airport lounge when I sent them out instead of using my giant screens at home).
-- brian m. carlson (they/them) Toronto, Ontario, CA