Re: [PATCH v6 2/5] reflog-walk: expose read_complete_reflog

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 26, 2025, 19:55 UTC
Message-ID: <aDTHSOodIuhBgZ_x@tapette.crustytoothpaste.net>
In-Reply-To: <b8a94020-0a7c-4d3b-92bc-a8a80b8d7af0@ramsayjones.plus.com>

On 2025-05-24 at 01:09:49, Ramsay Jones wrote:

Show 11 quoted lines

> So, at this point, 'git-compat-util.h' will already have been seen
> by the compiler (so it won't cause any problem, but equally it is
> not needed). In order to determine if the header can stand alone
> you should just need to:
> 
>     $ make reflog-walk.hco
> 
> [That is what the hdr-check target is for].
> 
> So, yes, include 'hash.h' to make the header file stand alone,
> but 'git-compat-util.h' should not be needed.

Okay, I'll change that here, but it does make clangd much less useful because `hash.h` does actually depend on `git-compat-util.h` and so clangd flags lots of missing types. Perhaps we should revisit that in the future.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA