From: Junio C Hamano Date: Thu, 22 May 2025 20:34:16 GMT Subject: Re: [PATCH v6 3/5] builtin/stash: factor out revision parsing into a function Message-ID: In-Reply-To: <20250522185524.18398-5-sandals@crustytoothpaste.net> "brian m. carlson" writes: > + strbuf_init(&info->revision, 0); > + if (parse_stash_revision(&info->revision, commit, 0)) { > + return -1; > } It does not look like this series add more code inside this block in a later step, so let's lose the unnecessary {braces} around a single statement "return -1" here. By the way, what is "pwodd" I saw in the e-mail header?