git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Mark http-fetch without -a as deprecated

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Aug 23, 2011, 07:02 UTC
Message-ID
<vpqvcto391x.fsf@bauges.imag.fr>
In-Reply-To
<1314060703-24265-1-git-send-email-bwalton@artsci.utoronto.ca>
Ben Walton <bwalton@artsci.utoronto.ca> writes:
> +	if (get_all == 0)
> +	  warning("http-fetch: use without -a is deprecated; -a will become the default in a future release");

Bad indentation. Git indents with tabs, not spaces. Also, you can break the line to make both the error message and the source code fit on 80 characters.

No opinion on whether the deprecation is sensible, though. If it is, add something in the documentation, not just in the code.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Ben WaltonNext: Ben Walton
Message 2 of 4 in “Mark http-fetch without -a as deprecated”
  1. Mark http-fetch without -a as deprecatedBen Walton, Aug 23, 2011
  2. Matthieu MoyAug 23, 2011
  3. Ben WaltonAug 23, 2011
  4. Mark http-fetch without -a as deprecatedBen Walton, Aug 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.