Re: [PATCH] Mark http-fetch without -a as deprecated
- From
Ben Walton <bwalton@artsci.utoronto.ca>
- Date
- Aug 23, 2011, 13:05 UTC
- Message-ID
- <1314104698-sup-1594@pinkfloyd.chass.utoronto.ca>
- In-Reply-To
- <vpqvcto391x.fsf@bauges.imag.fr>
Excerpts from Matthieu Moy's message of Tue Aug 23 03:02:02 -0400 2011:
Hi Matthieu,
> Bad indentation. Git indents with tabs, not spaces. Also, you can break > the line to make both the error message and the source code fit on 80 > characters.
Yes, sorry. Too much dependence on emacs 'doing the right thing' I guess. I'll fix both of these issues and resubmit.
> No opinion on whether the deprecation is sensible, though. If it is, > add something in the documentation, not just in the code.
Yes, good point. I'll include this documentation change as well.
Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302