threads / patch / 28197

patchMark http-fetch without -a as deprecated

Subject: [PATCH] Mark http-fetch without -a as deprecated

## tl;dr

4 messages between Aug 23, 2011 and Aug 24, 2011. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Ben Walton· Aug 23, 2011, 00:51 UTC · lore

As the use of http-fetch without -a can create an object store that is invalid to the point where it cannot even be fsck'd, mark it as deprecated. A future release should change the default and then remove the option entirely.

Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
---
 http-fetch.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to http-fetch.c +3 −0

diff --git a/http-fetch.c b/http-fetch.c
index 3af4c71..003ddb7 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -56,6 +56,9 @@ int main(int argc, const char **argv)
 		commits = 1;
 	}
 
+	if (get_all == 0)
+	  warning("http-fetch: use without -a is deprecated; -a will become the default in a future release");
+
 	if (argv[arg])
 		str_end_url_with_slash(argv[arg], &url);

-- 
1.7.4.1

Matthieu Moy· Aug 23, 2011, 07:02 UTC · re: Ben Walton · lore

Re: [PATCH] Mark http-fetch without -a as deprecated

Ben Walton <bwalton@artsci.utoronto.ca> writes:

> +	if (get_all == 0)
> +	  warning("http-fetch: use without -a is deprecated; -a will become the default in a future release");

Bad indentation. Git indents with tabs, not spaces. Also, you can break the line to make both the error message and the source code fit on 80 characters.

No opinion on whether the deprecation is sensible, though. If it is, add something in the documentation, not just in the code.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Ben Walton· Aug 23, 2011, 13:05 UTC · re: Matthieu Moy · lore

Re: [PATCH] Mark http-fetch without -a as deprecated

Excerpts from Matthieu Moy's message of Tue Aug 23 03:02:02 -0400 2011:

Hi Matthieu,

> Bad indentation. Git indents with tabs, not spaces. Also, you can break
> the line to make both the error message and the source code fit on 80
> characters.

Yes, sorry. Too much dependence on emacs 'doing the right thing' I guess. I'll fix both of these issues and resubmit.

> No opinion on whether the deprecation is sensible, though. If it is,
> add something in the documentation, not just in the code.

Yes, good point.  I'll include this documentation change as well.

Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302

Ben Walton· Aug 24, 2011, 00:29 UTC · re: Matthieu Moy · lore

Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
---
 Documentation/git-http-fetch.txt |    3 +++
 http-fetch.c                     |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)

Show changes to 2 files +7 −0

Documentation/git-http-fetch.txt, http-fetch.c

diff --git a/Documentation/git-http-fetch.txt b/Documentation/git-http-fetch.txt
index 4d42073..070cd1e 100644
--- a/Documentation/git-http-fetch.txt
+++ b/Documentation/git-http-fetch.txt
@@ -15,6 +15,9 @@ DESCRIPTION
 -----------
 Downloads a remote git repository via HTTP.
 
+*NOTE*: use of this command without -a is deprecated.  The -a
+behaviour will become the default in a future release.
+
 OPTIONS
 -------
 commit-id::
diff --git a/http-fetch.c b/http-fetch.c
index 3af4c71..8c4c5d2 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -56,6 +56,10 @@ int main(int argc, const char **argv)
 		commits = 1;
 	}
 
+	if (get_all == 0)
+		warning("http-fetch: use without -a is deprecated.\n"
+			"In a future release, -a will become the default.");
+
 	if (argv[arg])
 		str_end_url_with_slash(argv[arg], &url);

-- 
1.7.4.1