From: Matthieu Moy Date: Tue, 23 Aug 2011 07:02:02 GMT Subject: Re: [PATCH] Mark http-fetch without -a as deprecated Message-ID: In-Reply-To: <1314060703-24265-1-git-send-email-bwalton@artsci.utoronto.ca> Ben Walton writes: > + if (get_all == 0) > + warning("http-fetch: use without -a is deprecated; -a will become the default in a future release"); Bad indentation. Git indents with tabs, not spaces. Also, you can break the line to make both the error message and the source code fit on 80 characters. No opinion on whether the deprecation is sensible, though. If it is, add something in the documentation, not just in the code. -- Matthieu Moy http://www-verimag.imag.fr/~moy/