Re: [PATCH v4 03/18] sha1_name.c: get rid of ugly get_sha1_with_mode_1()

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 3, 2012, 08:01 UTC
Message-ID: <vpqsjd9nuid.fsf@bauges.imag.fr>
In-Reply-To: <1341268449-27801-4-git-send-email-gitster@pobox.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> +/*
> + * Call this function when you know "name" given by the end user must
> + * name an object but it doesn't; the function _may_ die with a better
> + * diagnostic message than "no such object 'name'", e.g. "Path 'doc' does not
> + * exist in 'HEAD'" when given "HEAD:doc", or it may return in which case
> + * you have a chance to diagnose the error further.
> + */
> +void die_on_misspelt_object_name(const char *name, const char *prefix)

It seems unusual to have a function named die_* that is not a noreturn function. I'd call it die_*_maybe, or diagnose_* instead.

(but as the comment above documents the behavior, it's not terribly important, you may ignore my comment if you whish)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/