Re: [PATCH 2/2] add: respect add.updateroot config option

Jeff King <peff@peff.net> writes:

I think the idea makes sense. The transition period is necessary for people who use different versions of Git (which includes anybody writting and distributing scripts), but for poor mortals who only use a single version of Git, it's nice to be able to jump to the future behavior once for all as soon as possible.

Your patch doesn't advertise the option in the warning message, which I think is good. You may mention it the commit message that this is a deliberate choice.

Detail: option names are normally camelCased => updateRoot.

I think the option name needs a bit more thinking. Without reading the doc,

[add]
	updateRoot = false

would be a very tempting thing to try. Perhaps explicitly warning when add.updateroot is set to false would avoid possible confusion.

In case you had missed it, here's a previous piece of discussion on the subject:

http://thread.gmane.org/gmane.comp.version-control.git/216818/focus=216846

I liked David's suggestion of using future.* to mean "start using behavior from the future right now".

Capital "Git".