[PATCH 1/2] add: update pathless 'add [-u|-A]' warning to reflect change of plan
- From
Matthieu Moy <matthieu.moy@imag.fr>
- Date
- Mar 11, 2013, 08:01 UTC
- Message-ID
- <1362988893-27539-1-git-send-email-Matthieu.Moy@imag.fr>
- In-Reply-To
- <vpqk3pefjs4.fsf@grenoble-inp.fr>
We originally thought the transition would need a period where "git add [-u|-A]" without pathspec would be forbidden, but the warning is big enough to scare people and teach them not to use it (or, if so, to understand the consequences).
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> --- builtin/add.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/add.c b/builtin/add.c index 0dd014e..ab1c9e8 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -328,9 +328,9 @@ static void warn_pathless_add(const char *option_name, const char *short_name) { * this is not the original behavior and can't be * changed until users trained themselves not to type * "git add -u" or "git add -A". For now, we warn and - * keep the old behavior. Later, this warning can be - * turned into a die(...), and eventually we may - * reallow the command with a new behavior. + * keep the old behavior. Later, the behavior can be changed + * to tree-wide, keeping the warning for a while, and + * eventually we can drop the warning. */ warning(_("The behavior of 'git add %s (or %s)' with no path argument from a\n" "subdirectory of the tree will change in Git 2.0 and should not be used anymore.\n"
-- 1.8.2.rc3.16.g0a33571.dirty