[PATCH 3/6] add: make warn_pathless_add() a no-op after first call
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 19, 2013, 22:45 UTC
- Message-ID
- <20130319224552.GD19014@google.com>
- In-Reply-To
- <20130319224400.GA19014@google.com>
Make warn_pathless_add() print its warning the first time it is called and do nothing if called again. This will make it easier to show the warning on the fly when a relevant condition is detected without risking showing it multiple times when multiple such conditions hold.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- As before.
builtin/add.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/builtin/add.c b/builtin/add.c index a4028ee..a424e69 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -33,8 +33,13 @@ static const char *short_option_with_implicit_dot; static void warn_pathless_add(void) { + static int shown; assert(option_with_implicit_dot && short_option_with_implicit_dot); + if (shown) + return; + shown = 1; + /* * To be consistent with "git add -p" and most Git * commands, we should default to being tree-wide, but
-- 1.8.2.rc3