Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 19, 2013, 05:44 UTC
Message-ID: <20130319054410.GQ5062@elie.Belkin>
In-Reply-To: <CACsJy8AjqwGVRRiQGMG0AN5qqtvxLk8FHKfUzCZB-7BykrHfjg@mail.gmail.com>

Duy Nguyen wrote:

Show 5 quoted lines

> My concern is run full-tree diff can be expensive on large repos (one
> of the reasons the user may choose to work from within a
> subdirectory). We can exit as soon as we find a difference outside
> $prefix. But in case we find nothing, we need to diff the whole
> worktree.

Yes. This is an argument for the single-diff approach that Junio suggested, since at least it's not significantly slower than the future default behavior ("git add -u :/").

Sysadmins and others helping to train users will need to make sure people working on large repos understand that they can use "git add -u ." to avoid a speed penalty.

Thanks for looking it over, Jonathan