Re: [PATCH] Revert "Stop starting pager recursively"

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 25, 2014, 18:49 UTC
Message-ID: <vpqoazpdz1r.fsf@anie.imag.fr>
In-Reply-To: <20140425182928.GA29904@logfs.org>

Jörn Engel <joern@logfs.org> writes:

Show 7 quoted lines

> On Mon, 21 April 2014 16:46:22 -0400, Jörn Engel wrote:
>> 
>> This reverts commit 88e8f908f2b0c56f9ccf8134d8ff9f689af9cc84.
>> 
>> Caused a usability regression for me and foul language for my coworkers.
>
> Ping.

How do you solve the problem that the commit you revert was solving? The commit you propose to revert says in its message:

    git-column can be used as a pager for other git commands, something
    like this:
    
        GIT_PAGER="git -p column --mode='dense color'" git -p branch
    
    The problem with this is that "git -p column" also has $GIT_PAGER set so
    the pager runs itself again as another pager. The end result is an
    infinite loop of forking.

There's probably a solution, but you can't ignore the problem (or someone else will later try to solve the infinite loop and revert your commit, and so on ...).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/