git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Revert "Stop starting pager recursively"

From
JEJörn Engel <joern@logfs.org>
Date
Apr 21, 2014, 20:46 UTC
Message-ID
<20140421204622.GA9532@logfs.org>
This reverts commit 88e8f908f2b0c56f9ccf8134d8ff9f689af9cc84.
Caused a usability regression for me and foul language for my coworkers.

In particular, I commonly do a "git log", with results going through less, find a potentially interesting commit and execute "git show <commit>" from less. This used to show the patch in less and no longer does.

Manually typing "git show <commit> | less" works, but is annoying,
wasting time and usually only done after seeing the mess from the simple
invocation.
---
 pager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pager.c b/pager.c
index 0cc75a8eee32..53670a63a7ae 100644
--- a/pager.c
+++ b/pager.c
@@ -64,7 +64,7 @@ void setup_pager(void)
 {
 	const char *pager = git_pager(isatty(1));
 
-	if (!pager || pager_in_use())
+	if (!pager)
 		return;
 
 	/*
-- 
1.9.1
Next: Jörn Engel
Message 1 of 13 in “Revert "Stop starting pager recursively"”
  1. Revert "Stop starting pager recursively"Jörn Engel, Apr 21, 2014
  2. Jörn EngelApr 25, 2014
  3. Matthieu MoyApr 25, 2014
  4. Jörn EngelApr 25, 2014
  5. Jeff KingApr 26, 2014
  6. Junio C HamanoApr 26, 2014
  7. Jeff KingApr 26, 2014
  8. Duy NguyenApr 27, 2014
  9. Jeff KingApr 27, 2014
  10. Matthieu MoyApr 27, 2014
  11. Jörn EngelApr 28, 2014
  12. Junio C HamanoApr 28, 2014
  13. Jörn EngelApr 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.