Re: [PATCH] Revert "Stop starting pager recursively"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 26, 2014, 17:27 UTC
- Message-ID
- <7vtx9ghuhg.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20140426071358.GA7558@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> [+cc Duy, whose patch this is] > > On Fri, Apr 25, 2014 at 04:10:49PM -0400, Jörn Engel wrote: > >> A second option is to add a --pager (or rather --no-pager) option to >> the command line and allow the user to specify >> GIT_PAGER="git --no-pager -p column --mode='dense color'" git -p branch > > I think we have "--no-pager" already. But the "-p" is turning _on_ the > pager, so you could also just omit it. IOW, I really don't understand > why the original command was not simply: > > GIT_PAGER="git column --mode='dense color'" git -p branch > > The whole infinite loop that the original commit solved is caused by > specifying the "-p". So it sounds like the right solution is "don't do > that". Am I missing something useful that the "-p" does?
My reading of this is that Duy wanted to let "-p" kick in to pass the columnized output, which could be more than a page long, thru the usual "less" or whatever pager.