Re: [PATCH] Revert "Stop starting pager recursively"

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 27, 2014, 02:12 UTC
Message-ID: <CACsJy8ANE+2n6fd-mF5pp+p2sXy_uRzJ2c+O=AiySyre+6KLtg@mail.gmail.com>
In-Reply-To: <20140426071358.GA7558@sigill.intra.peff.net>

On Sat, Apr 26, 2014 at 2:13 PM, Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

> [+cc Duy, whose patch this is]
>
> On Fri, Apr 25, 2014 at 04:10:49PM -0400, Jörn Engel wrote:
>
>> A second option is to add a --pager (or rather --no-pager) option to
>> the command line and allow the user to specify
>>     GIT_PAGER="git --no-pager -p column --mode='dense color'" git -p branch
>
> I think we have "--no-pager" already. But the "-p" is turning _on_ the
> pager, so you could also just omit it. IOW, I really don't understand
> why the original command was not simply:
>
>   GIT_PAGER="git column --mode='dense color'" git -p branch
>
> The whole infinite loop that the original commit solved is caused by
> specifying the "-p". So it sounds like the right solution is "don't do
> that". Am I missing something useful that the "-p" does?

The intent of the commit was "that is a stupid thing to do, but it's not so obvious from the first glance, do not freeze my system for my mistake". But if it stops an actual use case, then I agree it should be reverted.

Show 5 quoted lines

> I wonder if perhaps the intent was that the user might have set
> "pager.column", in which case the use of the pager is implied. I still
> think that the right solution is to use "--no-pager" explicitly then. If
> the user is invoking git inside GIT_PAGER, it is up to them to save
> themselves from infinite recursion.

-- Duy