git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 4/9] parse-options: add parse_opt_merge_filter()

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 8, 2015, 17:58 UTC
Message-ID
<vpqoakqozdr.fsf@anie.imag.fr>
In-Reply-To
<1433621052-5588-4-git-send-email-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 8 quoted lines
> +int parse_opt_merge_filter(const struct option *opt, const char *arg, int unset)
> +{
> +	struct ref_filter *rf = opt->value;
> +	unsigned char sha1[20];
> +
> +	rf->merge = opt->long_name[0] == 'n'
> +		? REF_FILTER_MERGED_OMIT
> +		: REF_FILTER_MERGED_INCLUDE;

I would use starts_with("no-", opt->long_name) instead. I had a hard time understanding why the letter 'n' was special while the starts_with() version is self-explanatory.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Karthik NayakNext: Karthik Nayak
Message 18 of 37 in “add options to ref-filter”
  1. 0/9 add options to ref-filterKarthik Nayak, Jun 6, 2015
  2. 1/9 tag: libify parse_opt_points_at()Karthik Nayak, Jun 6, 2015
  3. 2/9 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 6, 2015
  4. Matthieu MoyJun 8, 2015
  5. Karthik NayakJun 8, 2015
  6. Matthieu MoyJun 8, 2015
  7. Karthik NayakJun 8, 2015
  8. 3/9 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 6, 2015
  9. Matthieu MoyJun 8, 2015
  10. Karthik NayakJun 8, 2015
  11. Junio C HamanoJun 8, 2015
  12. Karthik NayakJun 9, 2015
  13. Junio C HamanoJun 9, 2015
  14. Karthik NayakJun 10, 2015
  15. Matthieu MoyJun 10, 2015
  16. Karthik NayakJun 10, 2015
  17. 4/9 parse-options: add parse_opt_merge_filter()Karthik Nayak, Jun 6, 2015
  18. Matthieu MoyJun 8, 2015
  19. Karthik NayakJun 8, 2015
  20. Junio C HamanoJun 8, 2015
  21. Karthik NayakJun 9, 2015
  22. 5/9 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 6, 2015
  23. Matthieu MoyJun 8, 2015
  24. Karthik NayakJun 8, 2015
  25. 6/9 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 6, 2015
  26. Matthieu MoyJun 8, 2015
  27. Karthik NayakJun 8, 2015
  28. 7/9 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 6, 2015
  29. Junio C HamanoJun 8, 2015
  30. Karthik NayakJun 9, 2015
  31. 8/9 ref-filter: add '--contains' optionKarthik Nayak, Jun 6, 2015
  32. 9/9 for-each-ref: add '--contains' optionKarthik Nayak, Jun 6, 2015
  33. Junio C HamanoJun 8, 2015
  34. Karthik NayakJun 9, 2015
  35. Christian CouderJun 7, 2015
  36. Karthik NayakJun 8, 2015
  37. Junio C HamanoJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.