git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 6/9] for-each-ref: add '--merged' and '--no-merged' options

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jun 8, 2015, 18:54 UTC
Message-ID
<5575E4C8.70101@gmail.com>
In-Reply-To
<vpq8ubursrh.fsf@anie.imag.fr>
On 06/08/2015 11:23 PM, Matthieu Moy wrote:
Show 22 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Add the '--merged' and '--no-merged' options provided by 'ref-filter'.
>> The '--merged' option lets the user to only list refs merged into the
>> named commit. The '--no-merged' option lets the user to only list refs
>> not merged into the named commit.
>>
>> Add documentation for the same.
>
> This also requires some tests. The algorithmic part will be validated by
> 'git tag --merged' using this library, but you need to check the
> codepath from the command-line to the lib in for-each-ref.
>
>> @@ -38,6 +39,8 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
>>   		OPT_CALLBACK(0, "points-at", &ref_cbdata.filter.points_at,
>>   			     N_("object"), N_("print only tags of the object"),
>>   			     parse_opt_points_at),
>> +		OPT_MERGED(&ref_cbdata.filter, N_("print only merged refs")),
>> +		OPT_NO_MERGED(&ref_cbdata.filter, N_("print only not merged refs")),
>
> I'd spell that "only refs that are not merged".
>

Like I mentioned, no tests were written. Will change that.

-- 
Regards,
Karthik
Previous: Matthieu MoyNext: Karthik Nayak
Message 27 of 37 in “add options to ref-filter”
  1. 0/9 add options to ref-filterKarthik Nayak, Jun 6, 2015
  2. 1/9 tag: libify parse_opt_points_at()Karthik Nayak, Jun 6, 2015
  3. 2/9 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 6, 2015
  4. Matthieu MoyJun 8, 2015
  5. Karthik NayakJun 8, 2015
  6. Matthieu MoyJun 8, 2015
  7. Karthik NayakJun 8, 2015
  8. 3/9 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 6, 2015
  9. Matthieu MoyJun 8, 2015
  10. Karthik NayakJun 8, 2015
  11. Junio C HamanoJun 8, 2015
  12. Karthik NayakJun 9, 2015
  13. Junio C HamanoJun 9, 2015
  14. Karthik NayakJun 10, 2015
  15. Matthieu MoyJun 10, 2015
  16. Karthik NayakJun 10, 2015
  17. 4/9 parse-options: add parse_opt_merge_filter()Karthik Nayak, Jun 6, 2015
  18. Matthieu MoyJun 8, 2015
  19. Karthik NayakJun 8, 2015
  20. Junio C HamanoJun 8, 2015
  21. Karthik NayakJun 9, 2015
  22. 5/9 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 6, 2015
  23. Matthieu MoyJun 8, 2015
  24. Karthik NayakJun 8, 2015
  25. 6/9 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 6, 2015
  26. Matthieu MoyJun 8, 2015
  27. Karthik NayakJun 8, 2015
  28. 7/9 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 6, 2015
  29. Junio C HamanoJun 8, 2015
  30. Karthik NayakJun 9, 2015
  31. 8/9 ref-filter: add '--contains' optionKarthik Nayak, Jun 6, 2015
  32. 9/9 for-each-ref: add '--contains' optionKarthik Nayak, Jun 6, 2015
  33. Junio C HamanoJun 8, 2015
  34. Karthik NayakJun 9, 2015
  35. Christian CouderJun 7, 2015
  36. Karthik NayakJun 8, 2015
  37. Junio C HamanoJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.