Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 7, 2016, 17:35 UTC
Message-ID: <vpqoa9ltj8g.fsf@anie.imag.fr>
In-Reply-To: <1460042563-32741-3-git-send-email-mst@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

Show 5 quoted lines

> it's sometimes useful to be able to pass output message of
> git-mailinfo through git-interpret-trailers,
> but that creates problems since that does not
> include the subject and an empty line after that,
> making interpret-trailers add an empty line.

Nit: we usually wrap our text around 72 columns in the commit message.
Yours is wrapped weirdly.

Show 8 quoted lines

> Add a flag to bypass adding the blank line.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  trailer.h                    |  2 +-
>  builtin/interpret-trailers.c |  9 +++++++--
>  trailer.c                    | 10 +++++++---
>  3 files changed, 15 insertions(+), 6 deletions(-)

You'd definitely need some tests and documentation if you introduce a new option.

No time for a real review, sorry.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/