Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 7, 2016, 16:55 UTC
- Message-ID
- <xmqqr3eh1hq6.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1460042563-32741-2-git-send-email-mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Allow -t as a short-cut for --trailer. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > ---
As I do not think interpret-trailers is meant to be end-user facing, I am not sure I should be interested in this step.
I am in principle OK with the later step that teaches a single letter option to end-user facing "git am" that would be turned into "--trailer" when it calls out to "interpret-trailers" (I haven't checked if 't' is a sensible choice for that single letter option, though).
Show 16 quoted lines
> builtin/interpret-trailers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c
> index b99ae4b..18cf640 100644
> --- a/builtin/interpret-trailers.c
> +++ b/builtin/interpret-trailers.c
> @@ -25,7 +25,7 @@ int cmd_interpret_trailers(int argc, const char **argv, const char *prefix)
> struct option options[] = {
> OPT_BOOL(0, "in-place", &in_place, N_("edit files in place")),
> OPT_BOOL(0, "trim-empty", &trim_empty, N_("trim empty trailers")),
> - OPT_STRING_LIST(0, "trailer", &trailers, N_("trailer"),
> + OPT_STRING_LIST('t', "trailer", &trailers, N_("trailer"),
> N_("trailer(s) to add")),
> OPT_END()
> };