From: Matthieu Moy Date: Thu, 07 Apr 2016 17:35:27 GMT Subject: Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line Message-ID: In-Reply-To: <1460042563-32741-3-git-send-email-mst@redhat.com> "Michael S. Tsirkin" writes: > it's sometimes useful to be able to pass output message of > git-mailinfo through git-interpret-trailers, > but that creates problems since that does not > include the subject and an empty line after that, > making interpret-trailers add an empty line. Nit: we usually wrap our text around 72 columns in the commit message. Yours is wrapped weirdly. > Add a flag to bypass adding the blank line. > > Signed-off-by: Michael S. Tsirkin > --- > trailer.h | 2 +- > builtin/interpret-trailers.c | 9 +++++++-- > trailer.c | 10 +++++++--- > 3 files changed, 15 insertions(+), 6 deletions(-) You'd definitely need some tests and documentation if you introduce a new option. No time for a real review, sorry. -- Matthieu Moy http://www-verimag.imag.fr/~moy/