git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] builtin/am: read mailinfo from file

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Apr 7, 2016, 15:23 UTC
Message-ID
<1460042563-32741-4-git-send-email-mst@redhat.com>
In-Reply-To
<1460042563-32741-1-git-send-email-mst@redhat.com>
Slightly slower, but will allow easy additional processing on it.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 builtin/am.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/builtin/am.c b/builtin/am.c
index d003939..4180b04 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -1246,6 +1246,7 @@ static int parse_mail(struct am_state *state, const char *mail)
 	FILE *fp;
 	struct strbuf sb = STRBUF_INIT;
 	struct strbuf msg = STRBUF_INIT;
+	struct strbuf log_msg = STRBUF_INIT;
 	struct strbuf author_name = STRBUF_INIT;
 	struct strbuf author_date = STRBUF_INIT;
 	struct strbuf author_email = STRBUF_INIT;
@@ -1330,7 +1331,12 @@ static int parse_mail(struct am_state *state, const char *mail)
 	}
 
 	strbuf_addstr(&msg, "\n\n");
-	strbuf_addbuf(&msg, &mi.log_message);
+
+	if (strbuf_read_file(&log_msg,  am_path(state, "msg"), 0) < 0) {
+		die_errno(_("could not read '%s'"), am_path(state, "msg"));
+	}
+
+	strbuf_addbuf(&msg, &log_msg);
 	strbuf_stripspace(&msg, 0);
 
 	if (state->signoff)
@@ -1349,6 +1355,7 @@ static int parse_mail(struct am_state *state, const char *mail)
 	state->msg = strbuf_detach(&msg, &state->msg_len);
 
 finish:
+	strbuf_release(&log_msg);
 	strbuf_release(&msg);
 	strbuf_release(&author_date);
 	strbuf_release(&author_email);
-- 
MST
Previous: Matthieu MoyNext: Junio C Hamano
Message 18 of 23 in “git-am: use trailers to add extra signatures”
  1. 0/4 git-am: use trailers to add extra signaturesMichael S. Tsirkin, Apr 7, 2016
  2. 1/4 builtin/interpret-trailers.c: allow -tMichael S. Tsirkin, Apr 7, 2016
  3. Junio C HamanoApr 7, 2016
  4. Matthieu MoyApr 7, 2016
  5. Junio C HamanoApr 7, 2016
  6. Michael S. TsirkinApr 7, 2016
  7. Michael S. TsirkinApr 7, 2016
  8. Junio C HamanoApr 7, 2016
  9. Michael S. TsirkinApr 7, 2016
  10. Junio C HamanoApr 7, 2016
  11. 2/4 builtin/interpret-trailers: suppress blank lineMichael S. Tsirkin, Apr 7, 2016
  12. Junio C HamanoApr 7, 2016
  13. Junio C HamanoApr 7, 2016
  14. Michael S. TsirkinApr 7, 2016
  15. Junio C HamanoApr 7, 2016
  16. Michael S. TsirkinApr 10, 2016
  17. Matthieu MoyApr 7, 2016
  18. 3/4 builtin/am: read mailinfo from fileMichael S. Tsirkin, Apr 7, 2016
  19. Junio C HamanoApr 7, 2016
  20. Michael S. TsirkinApr 7, 2016
  21. Matthieu MoyApr 7, 2016
  22. 4/4 builtin/am: passthrough -t and --trailer flagsMichael S. Tsirkin, Apr 7, 2016
  23. Christian CouderApr 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.