git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 3, 2015, 06:42 UTC
Message-ID
<vpqiob5fg24.fsf@anie.imag.fr>
In-Reply-To
<133653833.39653.1433262736640.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
Show 5 quoted lines
> Checking that the warning was correctly displayed like in the test for
> "warn" if I understood correctly. About that, is checking that the
> first line is "Warning: some commits may have been dropped
> accidentally." (like in the test for "warn") enough, or should I check
> that the commit displayed as removed is the correct one?

Ideally, you would check the list of commits displayed too. If the commits sha1 are stable, this should be easy to do. If it's too hard to test, I'd say its not worth the trouble, but others may disagree.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Junio C HamanoNext: Remi Galan Alfonso
Message 6 of 10 in “git-rebase -i: add command "drop" to remove a commit”
  1. 1/2 git-rebase -i: add command "drop" to remove a commitGalan Rémi, Jun 2, 2015
  2. 2/2 git rebase -i: warn about removed commitsGalan Rémi, Jun 2, 2015
  3. Matthieu MoyJun 2, 2015
  4. Remi Galan AlfonsoJun 2, 2015
  5. Junio C HamanoJun 2, 2015
  6. Matthieu MoyJun 3, 2015
  7. Remi Galan AlfonsoJun 3, 2015
  8. Remi Galan AlfonsoJun 3, 2015
  9. Matthieu MoyJun 2, 2015
  10. Remi Galan AlfonsoJun 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.