git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits

From
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date
Jun 3, 2015, 07:33 UTC
Message-ID
<921357851.51732.1433316800782.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To
<vpqiob5fg24.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Ideally, you would check the list of commits displayed too. If the
> commits sha1 are stable, this should be easy to do. If it's too hard to
> test, I'd say its not worth the trouble, but others may disagree.

Originally I chose not to check if the SHA-1 were corrects since check_commits was called right after expand_todo_ids and I thought that expand_todo_ids checked them, but from what I understand, it doesn't seem to check if the SHA-1 are commits, I could be wrong though.

Rémi
Previous: Matthieu MoyNext: Remi Galan Alfonso
Message 7 of 10 in “git-rebase -i: add command "drop" to remove a commit”
  1. 1/2 git-rebase -i: add command "drop" to remove a commitGalan Rémi, Jun 2, 2015
  2. 2/2 git rebase -i: warn about removed commitsGalan Rémi, Jun 2, 2015
  3. Matthieu MoyJun 2, 2015
  4. Remi Galan AlfonsoJun 2, 2015
  5. Junio C HamanoJun 2, 2015
  6. Matthieu MoyJun 3, 2015
  7. Remi Galan AlfonsoJun 3, 2015
  8. Remi Galan AlfonsoJun 3, 2015
  9. Matthieu MoyJun 2, 2015
  10. Remi Galan AlfonsoJun 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.