From: Matthieu Moy Date: Wed, 03 Jun 2015 06:42:59 GMT Subject: Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits Message-ID: In-Reply-To: <133653833.39653.1433262736640.JavaMail.zimbra@ensimag.grenoble-inp.fr> Remi Galan Alfonso writes: > Checking that the warning was correctly displayed like in the test for > "warn" if I understood correctly. About that, is checking that the > first line is "Warning: some commits may have been dropped > accidentally." (like in the test for "warn") enough, or should I check > that the commit displayed as removed is the correct one? Ideally, you would check the list of commits displayed too. If the commits sha1 are stable, this should be easy to do. If it's too hard to test, I'd say its not worth the trouble, but others may disagree. -- Matthieu Moy http://www-verimag.imag.fr/~moy/