git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFCv3 1/2] git-rebase -i: add command "drop" to remove a commit

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 2, 2015, 14:17 UTC
Message-ID
<vpqeglujisv.fsf@anie.imag.fr>
In-Reply-To
<1433252180-25591-1-git-send-email-remi.galan-alfonso@ensimag.grenoble-inp.fr>
Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
> +test_expect_success 'drop' '

Please, be more descriptive in the first argument of test_expect_success. It's usually a good thing to say not only what the test stresses but also what the expected behavior is.

test_expect_success 'drop actually drops the lines' '
	...
'
?
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Remi Galan AlfonsoNext: Remi Galan Alfonso
Message 9 of 10 in “git-rebase -i: add command "drop" to remove a commit”
  1. 1/2 git-rebase -i: add command "drop" to remove a commitGalan Rémi, Jun 2, 2015
  2. 2/2 git rebase -i: warn about removed commitsGalan Rémi, Jun 2, 2015
  3. Matthieu MoyJun 2, 2015
  4. Remi Galan AlfonsoJun 2, 2015
  5. Junio C HamanoJun 2, 2015
  6. Matthieu MoyJun 3, 2015
  7. Remi Galan AlfonsoJun 3, 2015
  8. Remi Galan AlfonsoJun 3, 2015
  9. Matthieu MoyJun 2, 2015
  10. Remi Galan AlfonsoJun 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.