Re: [PATCH 1/5] diff: parse separate options like -S foo

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Aug 5, 2010, 12:24 UTC
Message-ID: <vpqfwytxn6a.fsf@bauges.imag.fr>
In-Reply-To: <m3zkx1ntkk.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 10 quoted lines

> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>
>> +static inline int short_opt(char opt, const char **argv,
>> +			    const char **optarg)
> [...]
>> +int parse_long_opt(const char *opt, const char **argv,
>> +		   const char **optarg)
>
> Just a nitpick question: why it is 'parse_long_opt' but just
> 'short_opt'?

I initially made *_long_opt prefixed with something (diff_ in my first version) because it's global, while short_opt is static. parse_short_opt is already taken in parse-option.c, so I'd rather avoid re-using it (it's static there, so technically, we can, but ...).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/