git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.c: change the function signature of `git_config_string()`

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 23, 2014, 08:42 UTC
Message-ID
<vpqegxccvq9.fsf@anie.imag.fr>
In-Reply-To
<xmqqk375gx1n.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> *1* We have safe_create_leading_directories_const() that works
> around this for input parameter around its _const less counterpart,
> which is ugly but livable solution.

I think it would actually be a reasonable solution to avoid casting here and there on the caller side.

Another option would be to _return_ a non-const char * instead of outputing it as a by-address parameter. We'd lose the consiseness of

   return git_config_get_string(...)
(but in cases where the return value is ignored, we do not really care)
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 10 in “config.c: change the function signature of `git_config_string()`”
  1. config.c: change the function signature of `git_config_string()`Tanay Abhra, Jul 22, 2014
  2. Jeff KingJul 22, 2014
  3. Tanay AbhraJul 22, 2014
  4. Matthieu MoyJul 22, 2014
  5. Tanay AbhraJul 22, 2014
  6. Junio C HamanoJul 22, 2014
  7. Matthieu MoyJul 22, 2014
  8. Junio C HamanoJul 22, 2014
  9. Matthieu MoyJul 23, 2014
  10. Junio C HamanoJul 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.