From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 23 Jul 2014 08:42:06 GMT
Subject: Re: [PATCH] config.c: change the function signature of `git_config_string()`
Message-ID: <vpqegxccvq9.fsf@anie.imag.fr>
In-Reply-To: <xmqqk375gx1n.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> *1* We have safe_create_leading_directories_const() that works
> around this for input parameter around its _const less counterpart,
> which is ugly but livable solution.

I think it would actually be a reasonable solution to avoid casting here
and there on the caller side.

Another option would be to _return_ a non-const char * instead of
outputing it as a by-address parameter. We'd lose the consiseness of

   return git_config_get_string(...)

(but in cases where the return value is ignored, we do not really care)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/